Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get last updates and update to gnome 42 #12

Open
wants to merge 516 commits into
base: master
Choose a base branch
from

Conversation

fer-moreira
Copy link
Owner

No description provided.

@rowbawts
Copy link

Any update on this?

@DaveSpe
Copy link

DaveSpe commented May 12, 2022

Can we get an update on this? Gnome 42 is out there in the wilds.

@roryst
Copy link

roryst commented May 14, 2022

gnome 42, and everything breaking (as always), make me switch to cinnamon. i recommend it

@ran-dall
Copy link

ran-dall commented May 29, 2022

For those interested in trying this out, on Gnome 42, you can pull the repo, patch it, and build it...as follows...

  1. Pull the patch.
$ curl -L https://patch-diff.githubusercontent.com/raw/fer-moreira/floating-dock/pull/12.patch > ~/Desktop/gnome42.patch
  1. Pull the repo. (I pull it into ~/.local/share/gnome-shell/extensions/floating-dock)
$ git clone fer-moreira/floating-dock floating-dock
  1. Change into floating-dock directory.
cd ./floating-dock
  1. Apply patch
$ git apply --check --ignore-space-change --ignore-whitespace --3way  '~/Desktop/gnome42.patch'

NOTE: The patch expects schemas/org.gnome.shell.extensions.floating-dock.gschema.xml to be named schemas/org.gnome.shell.extensions.dash-to-dock.gschema.xml; as does the Makefile you'll need to use.

  1. Make
$ SASS=dart make

5, Install

$ make install

It should be noted there are still some errors; for example, on GNOME Extensions, it will kinda break, displaying a Main.panel._leftCorner is undefined error. It also shows that it can't be activated on GNOME Extensions, but clearly, it works.

Screenshot from 2022-05-29 06-34-30
Screenshot from 2022-05-29 06-36-06

Another minor error (a warning) will be displayed when performing Step 4.

$  SASS=dart make
glib-compile-schemas ./schemas/
sass --no-source-map _stylesheet.scss stylesheet.css
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($base-padding, 4) or calc($base-padding / 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
13 │ $dash_spacing: round($base_padding / 4);
   │                      ^^^^^^^^^^^^^^^^^
   ╵
    _stylesheet.scss 13:22  root stylesheet

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($dash-bottom-margin, 4) or calc($dash-bottom-margin / 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
19 │ $dock_side_margin: $dash_bottom_margin / 4;
   │                    ^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    _stylesheet.scss 19:20  root stylesheet

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($val, 4) or calc($val / 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
25 │     @return round($val / 4);
   │                   ^^^^^^^^
   ╵
    _stylesheet.scss 25:19  shrink()
    _stylesheet.scss 89:38  root stylesheet

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($dash-border-radius, 2) or calc($dash-border-radius / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
91 │                     border-radius: $dash_border_radius / 2;
   │                                    ^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    _stylesheet.scss 91:36  root stylesheet

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($dash-padding, 2) or calc($dash-padding / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
63 │                     margin: ($dash_spacing + ($dash_padding / 2)) 0;
   │                                               ^^^^^^^^^^^^^^^^^
   ╵
    _stylesheet.scss 63:47  root stylesheet

msgfmt -c po/ar.po -o po/ar.mo
msgfmt -c po/cs.po -o po/cs.mo
msgfmt -c po/de.po -o po/de.mo
msgfmt -c po/el.po -o po/el.mo
msgfmt -c po/es.po -o po/es.mo
msgfmt -c po/eu.po -o po/eu.mo
msgfmt -c po/fr.po -o po/fr.mo
msgfmt -c po/gl.po -o po/gl.mo
msgfmt -c po/hu.po -o po/hu.mo
msgfmt -c po/id.po -o po/id.mo
msgfmt -c po/it.po -o po/it.mo
msgfmt -c po/ja.po -o po/ja.mo
msgfmt -c po/nb.po -o po/nb.mo
msgfmt -c po/nl.po -o po/nl.mo
msgfmt -c po/pl.po -o po/pl.mo
msgfmt -c po/pt_BR.po -o po/pt_BR.mo
msgfmt -c po/pt.po -o po/pt.mo
msgfmt -c po/ru.po -o po/ru.mo
msgfmt -c po/sk.po -o po/sk.mo
msgfmt -c po/[email protected] -o po/[email protected]
msgfmt -c po/sr.po -o po/sr.mo
msgfmt -c po/sv.po -o po/sv.mo
msgfmt -c po/tr.po -o po/tr.mo
msgfmt -c po/uk_UA.po -o po/uk_UA.mo
msgfmt -c po/zh_CN.po -o po/zh_CN.mo
msgfmt -c po/zh_TW.po -o po/zh_TW.mo

@CristhoferMF
Copy link

it will be merged?
appears me same error
image

@martinszeltins
Copy link

What is the status of this? Since Ubuntu 22.04 is out, it would be nice to upgrade this extension to support GNOME 42

@rowbawts
Copy link

rowbawts commented Aug 8, 2022

Any news on this?

@lookto
Copy link

lookto commented Sep 3, 2022

A little update would be much appriciated :)

We prefer to use const when possible, so let's enforce it
That's simple enough to be handled internally
We still prefer to stay on 80, but slightly longer lines are still
allowed while it's an error to use something longer 110
It may imply looping through unwanted values, so let's avoid it.
This may be supported when using remote launcher actions
These information are only available when a widget is on the stage
These are safer because they perform an implicit existence check.
…ound

We're already doing a check for handler app in vfunc_launch(), so
there's no need to go through the same via vfunc_get_commandline()
It's supposed to be a void method
Otherwise it won't be possible to retry
GVfs implementations of GFile could cause the shell to hang while querying
the file infos, making the whole UI to freeze, and such actions can't be
cancelled, even if that's running in external processes.

To avoid this to happen, we need to use the async API and limit its
execution time to handle failures gracefully.

In case we also cache the last valid handler applications so that in case we
can re-use it on timeouts.

LP: #1997264
Sadly we can't use the new-window action directly because it does not
support adding further arguments.
3v1n0 and others added 29 commits August 27, 2024 11:11
No need to use two objects, we can use labeled connections to simplify
our case
If we're tracking an object destruction and that object gets destroyed,
we need to remove the signals handler storage item, or we'd end up
trying to disconnect from it again when destroying the signals handler.

Closes: #2270
The "Show Applications" button fails because the
Overview.ANIMATION_TIME property is now read-only (it has a
"const" prefix), so it's not possible to overwrite it to show
the applications list "instantaneously".

This patch removes the option of disabling the animation, thus
fixing the problem.
Let's handle unset values as undefined, as we should do
Don't use normal padding property here because we want the padding
to be proportional to the icons sizes
That includes the search results and the app folders contents
Only create the label and items if we are showing stuff, otherwise it's
just a waste.

Also update it on scale factor changes
If an application is a snap package, and the snap store is installed
we can show the snap packages details as we do for other non-snap
applications if GNOME Software is installed
While now there's only Cogl.Color, in previous versions we had both so
giving Cogl priority broke the theming support

Closes: #2307
By adding parameters in commit 611690c we ended up hiding the base
object constructor parameter, and so the support for automatic
disconnection on parent object destruction.

Fixes: #2297
This patch fixes the dot in Default mode when not enabling "Few
customizations".

Tested in Ubuntu Noble, Fedora 46 (100% and 200% scale), and
Ubuntu Oracular (both in Ubuntu Desktop and Classic Gnome
sessions).

Closes: #2222
@xcpn
Copy link

xcpn commented Nov 19, 2024

Very unfortunate this project is dead.

Been waiting for updates to come for GNOME 43+ so I can upgrade to Debian 12, but it seems like it'll never happen.

Is there any guide or a plan for someone to fork it so we can use it? I really dislike dash-to-dock and floating-dock was perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.